fix: regression in #662 causing segfaults #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/segfaultproj
branch
from
97c65bf to
74a52f4
Compare
1 task
henryiii
commented
Feb 15, 2022
Comment on lines
+201
to
+203
| auto cpp_values = py::cast<std::vector<unsigned>>(values); | ||
| py::gil_scoped_release release; | ||
| return bh::algorithm::project(self, | ||
| py::cast<std::vector<unsigned>>(values)); | ||
| return bh::algorithm::project(self, cpp_values); |
Member
Author
There was a problem hiding this comment.
This is the actual fix, I was running Python API via py::cast inside a GIL-less section! I'm also now catching this error before it happens in Python, which should make limited EH environments like pyodide happier. Plus we get a nicer error message & error class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important fix, requiring 2.3.1.
Nicer error message and avoids catching a C++ error if possible.