Skip to content

refactor: drop cpp #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2020
Merged

refactor: drop cpp #402

merged 3 commits into from
Jul 10, 2020

Conversation

@henryiii
Copy link
Member

@henryiii henryiii commented Jul 10, 2020 •
edited
Loading

This removes the cpp interface (over 500 loc so far). Some further simplification should be possible by removing the Base* versions. Done, now 700 loc removed.

@henryiii henryiii mentioned this pull request Jul 10, 2020
Merged
@henryiii henryiii marked this pull request as ready for review July 10, 2020 23:46
@henryiii henryiii merged commit 98ddba8 into develop Jul 10, 2020
@henryiii henryiii deleted the refactor/dropcpp branch July 10, 2020 23:56
@henryiii
Copy link
Member Author

henryiii commented Jul 11, 2020

Most of #381 addressed here. Might be a little more to clean up.

@henryiii henryiii mentioned this pull request Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henryiii