fix: version not a string (typing updates) #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 89.39% 89.40% +0.01%
==========================================
Files 50 50
Lines 2131 2134 +3
==========================================
+ Hits 1905 1908 +3
Misses 226 226
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
henryiii
commented
Mar 17, 2023
Comment on lines
-97
to
+100
| version=dist.get_version(), | ||
| version=Version(dist.get_version()), |
Collaborator
Author
There was a problem hiding this comment.
This was an actual mistake! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to upstream were released quicker than I thought! :)