feat: cross-compile to Windows ARM #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
dependabot/github_actions/pypa/cibuildwheel-2.11.3
to
master
December 19, 2022 20:13
henryiii
force-pushed
the
henryiii-patch-1
branch
2 times, most recently
from
f5d8e03 to
ace41cc
Compare
|
Thanks for working on this 🙏 🚀 If relevant, let's also make sure to update scripts/update_cmake_version.py |
|
Oops, yes, you are right, I forgot about that. My next step is to bump to the next patch version, so I’d have hit it there. Much better preemptive! |
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii-patch-1
branch
from
ace41cc to
b76805e
Compare
|
Update seems to work locally. |
|
Ah, also todo: probably should check this. Since we are just downloading the ARM binary, I'd expect it to be fine, but let's make sure. It does bother me that no tests failed. |
jcfr
added a commit
to jcfr/cmake-python-distributions
that referenced
this pull request
Jun 7, 2023
This commit fixes a regression introduced in 6674721 (feat: cross-compile to Windows ARM (scikit-build#326)). It ensures the arm64 CMake binary package is downloaded when building the corresponding CMake Windows arm64 wheels. Co-authored-by: Henry Schreiner <[email protected]>
jcfr
added a commit
to jcfr/cmake-python-distributions
that referenced
this pull request
Jun 7, 2023
This commit fixes a regression introduced in 6674721 (feat: cross-compile to Windows ARM (scikit-build#326)). It ensures the arm64 CMake binary package is downloaded when building the corresponding CMake Windows arm64 wheels. Co-authored-by: Henry Schreiner <[email protected]>
jcfr
added a commit
to jcfr/cmake-python-distributions
that referenced
this pull request
Jun 7, 2023
This commit fixes a regression introduced in 6674721 (feat: cross-compile to Windows ARM (scikit-build#326)). It ensures the arm64 CMake binary package is downloaded when building the corresponding CMake Windows arm64 wheels. Co-authored-by: Henry Schreiner <[email protected]>
jcfr
added a commit
that referenced
this pull request
Jun 7, 2023
This commit fixes a regression introduced in 6674721 (feat: cross-compile to Windows ARM (#326)). It ensures the arm64 CMake binary package is downloaded when building the corresponding CMake Windows arm64 wheels. Co-authored-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.