Skip to content

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Nov 10, 2023

No description provided.

@yfodil yfodil added enhancement observability Cockpit observability issues, bugs and feature requests labels Nov 10, 2023
@yfodil yfodil self-assigned this Nov 10, 2023
@yfodil yfodil linked an issue Nov 10, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6326dc) 73.23% compared to head (1ba9f9c) 73.25%.

❗ Current head 1ba9f9c differs from pull request most recent head c3c6dd6. Consider uploading reports for the commit c3c6dd6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
+ Coverage   73.23%   73.25%   +0.02%     
==========================================
  Files         213      213              
  Lines       33713    33739      +26     
==========================================
+ Hits        24691    24717      +26     
  Misses       6895     6895              
  Partials     2127     2127              
Files Coverage Δ
scaleway/helpers_cockpit.go 84.41% <100.00%> (+1.08%) ⬆️
scaleway/resource_cockpit.go 71.76% <100.00%> (+0.85%) ⬆️
scaleway/resource_cockpit_token.go 87.93% <100.00%> (+1.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Nov 10, 2023
Merged via the queue into scaleway:master with commit 9245633 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement observability Cockpit observability issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Cockpit traces

3 participants