Skip to content

Conversation

@Mia-Cross
Copy link
Contributor

Closes #2046

The provider didn't allow changes to node_type or volume_size_in_gb once the instance reached disk_full status. This is because both these attributes belong in the upgrades category and it tried to perform the updates before, which failed since the resource is in a transient state.

This PR fixes the issue by performing the upgrades first and adds a bit of documentation on how to deal with a disk_full situation with Terraform.

@Mia-Cross Mia-Cross self-assigned this Nov 2, 2023
@Mia-Cross Mia-Cross marked this pull request as draft November 2, 2023 18:37
@Mia-Cross Mia-Cross force-pushed the rdb_node_type_update branch from 9ed7fb6 to be8e1c9 Compare November 2, 2023 18:46
@codecov-commenter
Copy link

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (1339bd5) 73.28% compared to head (d39302b) 73.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
- Coverage   73.28%   73.23%   -0.05%     
==========================================
  Files         212      212              
  Lines       33367    33388      +21     
==========================================
- Hits        24453    24452       -1     
- Misses       6817     6838      +21     
- Partials     2097     2098       +1     
Files Coverage Δ
scaleway/resource_rdb_instance.go 70.67% <24.63%> (-1.31%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross force-pushed the rdb_node_type_update branch from d39302b to d6ba18c Compare November 6, 2023 10:28
@Mia-Cross Mia-Cross marked this pull request as ready for review November 6, 2023 10:35
@remyleone remyleone added this pull request to the merge queue Nov 6, 2023
Merged via the queue into scaleway:master with commit 1df2fd0 Nov 6, 2023
@Mia-Cross Mia-Cross deleted the rdb_node_type_update branch November 6, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RDB node_type update is failing

3 participants