test(k8s): add a private network to every kapsule cluster in the tests #2172
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
- Coverage 73.36% 73.31% -0.06%
==========================================
Files 212 212
Lines 33262 33271 +9
==========================================
- Hits 24403 24392 -11
- Misses 6764 6787 +23
+ Partials 2095 2092 -3
☔ View full report in Codecov by Sentry. |
Mia-Cross
force-pushed
the
k8s_add_pn_to_all_tests
branch
from
0f04931 to
4cb6c95
Compare
scaleway/resource_k8s_pool_test.go
Outdated
| tags = [ "terraform-test", "scaleway_k8s_cluster", "placement_group" ] | ||
| region = "nl-ams" | ||
| delete_additional_resources = true | ||
| delete_additional_resources = false |
There was a problem hiding this comment.
Why does this line need to be changed?
There was a problem hiding this comment.
It's because the cluster gets destroyed and another one is created between step 1 and 2 of the test and if delete_additional_resources is set to true, the private network gets destroyed with it since it's empty and considered an additional resource of the cluster.
I could also switch back to true and create a new private network in the second step if it's better.
I don't think that there were any dangling resources though.
There was a problem hiding this comment.
Apparently there was no need for this particular change so I rolled-back.
Mia-Cross
force-pushed
the
k8s_add_pn_to_all_tests
branch
from
3234c50 to
841061e
Compare
3 participants
No description provided.