Skip to content

fix: set different record names on instance & vpcgw ip reverse tests #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2023
Merged

fix: set different record names on instance & vpcgw ip reverse tests #1928

merged 4 commits into from
May 12, 2023

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented May 11, 2023

No description provided.

@yfodil yfodil added bug instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels May 11, 2023
@yfodil yfodil self-assigned this May 11, 2023
@yfodil yfodil marked this pull request as draft May 11, 2023 14:58
@yfodil yfodil marked this pull request as ready for review May 12, 2023 11:32
@yfodil yfodil changed the title fix: set different dns_zones and record names on instance & vpcgw ip reverse tests fix: set different record names on instance & vpcgw ip reverse tests May 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #1928 (3b660f0) into master (60a69be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1928   +/-   ##
=======================================
  Coverage   73.97%   73.97%           
=======================================
  Files         176      176           
  Lines       27509    27509           
=======================================
  Hits        20350    20350           
  Misses       5429     5429           
  Partials     1730     1730

@yfodil yfodil added this pull request to the merge queue May 12, 2023
Merged via the queue into scaleway:master with commit cc82175 May 12, 2023
@yfodil yfodil deleted the set_different_name_records branch May 12, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Codelax Codelax Codelax approved these changes

Assignees

@yfodil yfodil

Labels

bug instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yfodil @codecov-commenter @Codelax