Skip to content

feat(mnq): queue resource #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 11, 2023
Merged

feat(mnq): queue resource #1903

merged 23 commits into from
May 11, 2023

Conversation

@quantumsheep
Copy link
Member

@quantumsheep quantumsheep commented Apr 19, 2023

Relates to #1761

@quantumsheep quantumsheep added the mnq Messaging and queuing issues, bugs and feature requests label Apr 19, 2023
@quantumsheep quantumsheep self-assigned this Apr 19, 2023
@quantumsheep quantumsheep force-pushed the feat/resource-mnq-queue branch from 7803dfb to 1442287 Compare April 19, 2023 16:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023 •
edited
Loading

Codecov Report

Merging #1903 (e435836) into master (931bfcd) will decrease coverage by 0.48%.
The diff coverage is 56.81%.

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
- Coverage   74.45%   73.97%   -0.48%     
==========================================
  Files         174      176       +2     
  Lines       26808    27509     +701     
==========================================
+ Hits        19960    20350     +390     
- Misses       5159     5429     +270     
- Partials     1689     1730      +41
Impacted Files Coverage Δ
scaleway/helpers_object.go 62.30% <ø> (+0.08%) ⬆️
scaleway/helpers_mnq_queue.go 52.77% <52.77%> (ø)
scaleway/resource_mnq_queue.go 55.38% <55.38%> (ø)
scaleway/helpers.go 70.93% <58.62%> (-0.56%) ⬇️
scaleway/provider.go 79.15% <100.00%> (+0.06%) ⬆️
scaleway/resource_object_bucket.go 79.83% <100.00%> (+0.20%) ⬆️
scaleway/resource_object_bucket_acl.go 81.94% <100.00%> (+0.15%) ⬆️
...leway/resource_object_bucket_lock_configuration.go 73.85% <100.00%> (+0.36%) ⬆️
...ay/resource_object_bucket_website_configuration.go 71.13% <100.00%> (+0.35%) ⬆️

@quantumsheep quantumsheep force-pushed the feat/resource-mnq-queue branch from 6f0eada to fbc9010 Compare April 21, 2023 14:43
@quantumsheep quantumsheep marked this pull request as ready for review April 21, 2023 14:51
remyleone
remyleone reviewed Apr 21, 2023
View reviewed changes
remyleone
remyleone reviewed Apr 24, 2023
View reviewed changes
Monitob
Monitob reviewed Apr 24, 2023
View reviewed changes
Codelax
Codelax reviewed Apr 25, 2023
View reviewed changes
Codelax
Codelax requested changes Apr 26, 2023
View reviewed changes
@remyleone remyleone added the priority:highest Bugs filled by customers, security issues label May 2, 2023
@quantumsheep quantumsheep force-pushed the feat/resource-mnq-queue branch 2 times, most recently from 65a712f to 08b49f3 Compare May 3, 2023 15:43
@quantumsheep
feat(mnq): resource queue
f6236a2 
feat(mnq): add read and update queue sqs

feat(mnq): sqs queues

fix linter issues

feat: add nats

refactor: underscore unused function parameters

docs: add documentation

remove unused cassette

remove code from another MR

fix: ignore `time.Sleep` linter issue

docs(mnq): fix sqs example namespace protocol

fix: remove double error

feat(mnq): set sqs specific url

fix(mnq): if name_prefix is not set then it will never be

feat(cockpit): don't require token scopes (#1905)

feat(mnq): generate queue name

feat(mnq): use NATS jetstream and improve tests

refactor: replace `retryWhenAWSErrCodeEquals` by `retryOnAWSCode`
@quantumsheep quantumsheep force-pushed the feat/resource-mnq-queue branch from 08b49f3 to f6236a2 Compare May 3, 2023 15:48
Codelax
Codelax reviewed May 9, 2023
View reviewed changes
Monitob
Monitob previously approved these changes May 9, 2023
View reviewed changes
Monitob
Monitob previously approved these changes May 9, 2023
View reviewed changes
@remyleone remyleone enabled auto-merge May 10, 2023 09:21
remyleone
remyleone previously approved these changes May 10, 2023
View reviewed changes
Codelax
Codelax reviewed May 10, 2023
View reviewed changes
@quantumsheep quantumsheep dismissed stale reviews from remyleone and Monitob via 5bab90b May 10, 2023 11:34
@quantumsheep quantumsheep requested a review from Codelax May 10, 2023 11:34
Codelax
Codelax requested changes May 11, 2023
View reviewed changes
@quantumsheep quantumsheep requested a review from Codelax May 11, 2023 13:28
@remyleone remyleone added this pull request to the merge queue May 11, 2023
Merged via the queue into master with commit 60a69be May 11, 2023
@remyleone remyleone deleted the feat/resource-mnq-queue branch May 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Codelax Codelax Codelax approved these changes

@remyleone remyleone remyleone left review comments

+1 more reviewer

@Monitob Monitob Monitob left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@quantumsheep quantumsheep

Labels

enhancement mnq Messaging and queuing issues, bugs and feature requests priority:highest Bugs filled by customers, security issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@quantumsheep @codecov-commenter @remyleone @Monitob @Codelax