feat(domain): add WaitForDNSRecordNotExist waiter #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
reviewed
Sep 4, 2025
| return dns.(*Record), nil | ||
| } | ||
|
|
||
| // WaitForDNSRecordNotExistRequest is used by WaitForDNSRecordNotExist method. |
Member
There was a problem hiding this comment.
Not helpful comment please remove it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2665 +/- ##
=========================================
- Coverage 3.75% 3.75% -0.01%
=========================================
Files 152 152
Lines 48548 48570 +22
=========================================
Hits 1823 1823
- Misses 46446 46468 +22
Partials 279 279 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.