Skip to content

Update SDK for v2 APIs #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2025
Merged

Conversation

EvanWang2
Copy link
Contributor

@EvanWang2 EvanWang2 commented Jul 14, 2025

Description

How did you test your code?

Which of the following have you done to test your changes? Please describe the tests that you ran to verify your changes.

  • Created new unit tests in tests/ for the newly implemented methods
  • Updated existing unit tests in tests/ to cover changes made to existing methods

Checklist

Please make sure all items in this checklist have been fulfilled before sending your PR out for review!

  • I have commented my code in details, particularly in hard-to-understand areas
  • I have updated Readme.rst document with examples for newly implemented public methods
  • I have reviewed Deployment and Publishing Guide for Python SDK document
  • I incremented the SDK version in _version.py (unless this PR only updates the documentation).
  • In order to release a new version, a "Release Summary" needs to be prepared and published after the merge

@EvanWang2 EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from 226279a to 20a7bc8 Compare July 14, 2025 03:41
@EvanWang2 EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from 20a7bc8 to 186f18e Compare July 14, 2025 03:47
Copy link
Collaborator

@michaelbishoff michaelbishoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget why this file is commented out, but can we add some tests here that use only the v2 APIs. The tests ensure that the generated client is valid (we saw an edge case where oneOf properties in the openapi.yaml file didn't generate correctly)

https://github.com/scaleapi/scaleapi-python-client/blob/master/tests/test_v2_client.py

Copy link
Collaborator

@michaelbishoff michaelbishoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EvanWang2 EvanWang2 force-pushed the evan/CONN-421/update-sdk-for-v2-apis branch from dc87fa2 to a17b1bb Compare July 17, 2025 23:06
@EvanWang2
Copy link
Contributor Author

Unable to create a chat project with template variables in the test SDK environment, so there are no tests for task creation and fetching. The test API key I use doesn't associate with the projects under my account.

@EvanWang2 EvanWang2 merged commit 7829731 into master Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants