Skip to content

Create project returns async job #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create project returns async job #111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1112a0
change create from project endpoint to return an async job
sasha-scale Aug 31, 2021
b00be62
add missing argument
sasha-scale Sep 1, 2021
751690f
minor improvements
sasha-scale Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions nucleus/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,12 @@ def delete_model_run(self, model_run_id: str):
)

def create_dataset_from_project(
self, project_id: str, last_n_tasks: int = None, name: str = None
) -> Dataset:
self,
project_id: str,
name: str = None,
last_n_tasks: int = None,
exclude_pending: bool = None,
) -> Tuple[Dataset, AsyncJob]:
"""
Creates a new dataset based on payload params:
name -- A human-readable name of the dataset.
Expand All @@ -312,8 +316,16 @@ def create_dataset_from_project(
payload["last_n_tasks"] = str(last_n_tasks)
if name:
payload["name"] = name
if exclude_pending:
payload["exclude_pending"] = exclude_pending
response = self.make_request(payload, "dataset/create_from_project")
return Dataset(response[DATASET_ID_KEY], self)
return Dataset(response[DATASET_ID_KEY], self), AsyncJob(
job_id=response[JOB_ID_KEY],
job_last_known_status=response[JOB_LAST_KNOWN_STATUS_KEY],
job_type=response[JOB_TYPE_KEY],
job_creation_time=response[JOB_CREATION_TIME_KEY],
client=self,
)

def create_dataset(
self,
Expand Down