Skip to content

Fix string interpolation with curly braces #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix string interpolation with curly braces #71

merged 1 commit into from
Jan 13, 2020

Conversation

@kiendang
Copy link
Contributor

@kiendang kiendang commented Dec 3, 2019

Currently string interpolation doesn't work properly when there are curly braces inside the expression. This PR fixes that.

Before
Screen Shot 2019-12-04 at 12 46 55 AM
After
Screen Shot 2019-12-04 at 12 47 43 AM

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jan 10, 2020

Thanks @kiendang. Could you also add some tests in tests/unit?

Does this by any chance also fixes #72?

@nicolasstucki nicolasstucki self-requested a review January 10, 2020 09:15
@kiendang
Copy link
Contributor Author

kiendang commented Jan 11, 2020

Unit tests added.

No this doesn't fix #72. I opened a separate PR to fix that in #74.

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jan 13, 2020

Thanks @kiendang

@nicolasstucki nicolasstucki merged commit 37c1f36 into scala:master Jan 13, 2020
@kiendang kiendang deleted the interpolation branch January 13, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kiendang @nicolasstucki