Skip to content

Conversation

@MaximeKjaer
Copy link
Contributor

I followed the Travis CI guide for deploying to GitHub releases. I can't really test it, so I guess we'll see at the next release! Worst case, if it fails, it's the last deployment step, and therefore won't affect the previous deployment steps.

.travis.yml Outdated
deploy:
provider: releases
skip_cleanup: true
file: syntaxes/Scala.tmLanguage.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #75 is about the missing .vsix file. The Scala.tmLanguage.json already included in the sources zip artefact.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've amended the commit to fix this

@nicolasstucki nicolasstucki merged commit bca5480 into scala:master Jul 19, 2020
@nicolasstucki
Copy link
Contributor

I'll make a release at some point this week and test this.

@MaximeKjaer
Copy link
Contributor Author

I'll keep an eye out, but please do ping me if it crashes

@nicolasstucki
Copy link
Contributor

It failed, I had to add the vsix manually to https://github.com/scala/vscode-scala-syntax/releases/tag/0.4.2

@MaximeKjaer MaximeKjaer deleted the travis-ci-releases branch September 11, 2020 07:52
@MaximeKjaer MaximeKjaer mentioned this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants