Cache also private members #9648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a full cache instead of an LRU cache. For `typer/*.scala`, this reduced computed member searches on normal ClassDenotations from 520K to 170K. Cache hit rate improves to 97.5%, from 92.5%. (Without member caching there are almost 7Mio computed members for the same code base).
The two implementation classes of LinearTable had so much in common that they could be combined. Since the implementation is now fixed, we can use the usual mutable interface for a table.
When going from dense to hashed, we should expand by a multiple greater than two, or we will have to reallocate immediately afterwards.
We get occasional failures of the form java.lang.AssertionError: assertion failed: asTerm called on not-a-Term val <none> while compiling tests/pos/projections.scala Fatal compiler crash when compiling: tests/pos/projections.scala: assertion failed: asTerm called on not-a-Term val <none> dotty.DottyPredef$.assertFail(DottyPredef.scala:17) dotty.tools.dotc.core.Symbols$Symbol.asTerm(Symbols.scala:156) when compiling pos/projections.scala with FromTasty tests. It was first observed when we parallelized position pickling, so it might have something to do with that.
NoDenotation is a frequent result, so we should keep post processing it as simple as possible. As a side effect this now forces less, which makes some previously failing tests pass. I updated i3253.scala so that it fails again and moved i9052 to pos.
This means we have to do extra work for a nonPrivateMember that hits a private member. But that's probably not a very common case. On the other hand, every find member operation needs one less scope lookup this way.
This reverts commit f8d6ac4.
odersky
force-pushed
the
private-member-caching
branch
from
2bdee9e to
44a07d6
Compare
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9648/ to see the changes. Benchmarks is based on merging with master (2e58a66) |
liufengyun
approved these changes
Aug 31, 2020
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
myMemberCache is not copied when we create a new ClassDenotation from an existing one (See copyCaches). I assume that is OK, as when we copy a ClassDenotation, usually its member cache becomes invalid.
Co-authored-by: Fengyun Liu <[email protected]>
Contributor
Author
|
Yes, not copying member caches is intentional since then we do not have to worry about validity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep private members in member caches as well.
This means we have to do extra work for a nonPrivateMember call
that hits a private member. But that's probably not a very
common case. On the other hand, every regular findMember operation
needs one less scope lookup this way.