Remove mixin traits of Context #9343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
change-using
branch
5 times, most recently
from
bce1767 to
37e4b27
Compare
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
performance test failed: Please check http://lamppc37.epfl.ch:8000/pull-9343-07-14-22.32.out for more information |
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Contributor
|
From the logs: |
Member
|
performance test failed: Please check http://lamppc37.epfl.ch:8000/pull-9343-07-15-10.12.out for more information |
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9343/ to see the changes. Benchmarks is based on merging with master (001817c) |
Contributor
Author
|
We seem to have a small but significant improvement of performance in stdlib compilation. The rest is more or less the same. The compiler itself is a little bit slower, which is to be expected since there are now many more implicit searches than before. |
Contributor
Author
|
Squashed to one commit to allow for easier rebasing |
odersky
force-pushed
the
change-using
branch
2 times, most recently
from
c09830d to
3524a5b
Compare
odersky
force-pushed
the
change-using
branch
3 times, most recently
from
95b56a8 to
b81cc98
Compare
Stats show that importInfo is updated about 10x less that Store. E.g. compiling Dotty: Total context creations: 5.6M Store creations: 68K Import info creations: 6.8K So this means we save 22.4M be removing importInfo as a field of contexts at a price of less than 600K for the added store creations. # Conflicts: # compiler/src/dotty/tools/dotc/core/Contexts.scala
Use a freelist of unsused contexts instead of overwriting typerstate variables. Rename from `ctx.test` to `explore`.
Also:
- Change functions from Context to context functions
- Rename ctx.erasedTypes -> currentlyAfterErasure
ctx.isAfterTyper -> currentlyAfterTyper
- Add currentPhase, currentPeriod, ... utility methods
- Replace `c.runId` by `currentRunId(using c)`. This can be
changed back again if we end up not splitting period info
from contexts
- Add inMode, withMode, withoutMode utility wrappers
- Move error messages directly into reporting: this avoids
an annoying import
- Use only wildcard imports from Contexts - Use `(using Context)` throughout
- `newSymbol`, `requiredSymbol` etc, now are available from Symbols, no `ctx.` prefix needed - All reporing methods are available from `report` object. Also: - Change functions from Context to context functions. - Add atPhase, atPhaseNoLater, addPhaseNoEarlier and have them replace most uss of `withPhase`... - Add inMode, withMode, withoutMode utility wrappers - Move error messages directly into reporting: this avoids an annoying import - Convert old style implicit parameters to `(using Context)` - Reorganize TyperState.test: Instead of overwriting fields of TyperState, keep test contexts in an explicit stack, so that they can be re-used. This is simpler and since there is more decoupling between tests. Usage is now `Contexts.explore(...)` instead of `ctx.test(...)`. # Conflicts: # compiler/src/dotty/tools/dotc/core/Definitions.scala # Conflicts: # compiler/src/dotty/tools/dotc/Run.scala # compiler/src/dotty/tools/dotc/core/Annotations.scala # compiler/src/dotty/tools/dotc/core/Contexts.scala # compiler/src/dotty/tools/dotc/core/Definitions.scala # compiler/src/dotty/tools/dotc/core/Phases.scala # compiler/src/dotty/tools/dotc/core/TyperState.scala # compiler/src/dotty/tools/dotc/core/Types.scala # compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala # compiler/src/dotty/tools/dotc/transform/ExplicitOuter.scala # compiler/src/dotty/tools/dotc/transform/TreeChecker.scala # compiler/src/dotty/tools/dotc/typer/Namer.scala
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 0 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9343/ to see the changes. Benchmarks is based on merging with master (883198c) |
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jul 23, 2020
anatoliykmetyuk
added a commit
that referenced
this pull request
Jul 23, 2020
Fix sbt scripted tests after refactor in #9343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
newSymbol,requiredSymboletc, now are availablefrom Symbols, no
ctx.prefix neededreportobject.It's clearer to make them regular objects. Also:
most uss of
withPhase...an annoying import
(using Context)contexts in an explicit stack, so that they can be re-used. This is simpler and
since there is more decoupling between tests. Usage is now
Contexts.explore(...)instead ofctx.test(...).