Skip to content

Fix #9109: More precise override check #9139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Jun 9, 2020

Use Denotation#matches instead of Types#matches, the former takes
signatures into account, in the testcase this is needed to ensure that
RefChecks does not emit an error about
def foo[T <: Serializable](x: T): Unit being an invalid override of
def foo[T <: Cloneable](x: T): Unit.

Note that our treatment of polymorphic methods differs from Scala 2
which seems to consider that two polymorphic methods with the same
number of type and term parameters always match and cannot be
overloads (see #8929), but it's closer to what Java does and allows us
to override some Java methods which scalac can't.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

Use Denotation#matches instead of Types#matches, the former takes
signatures into account, in the testcase this is needed to ensure that
RefChecks does not emit an error about
`def foo[T <: Serializable](x: T): Unit` being an invalid override of
`def foo[T <: Cloneable](x: T): Unit`.

Note that our treatment of polymorphic methods differs from Scala 2
which seems to consider that two polymorphic methods with the same
number of type and term parameters always match and cannot be
overloads (see scala#8929), but it's closer to what Java does and allows us
to override some Java methods which scalac can't.
@smarter smarter force-pushed the polymorphic-override branch from 6ec9a7a to 7964d17 Compare June 9, 2020 13:19
@smarter smarter changed the title Fixes #9109: More precise override check Fix #9109: More precise override check Jun 9, 2020
@smarter smarter requested a review from odersky June 9, 2020 14:01
@odersky odersky merged commit 74cfd84 into scala:master Jun 9, 2020
@odersky odersky deleted the polymorphic-override branch June 9, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants