Skip to content

Conversation

@typeness
Copy link

@typeness typeness commented May 5, 2020

The issue was closed #1589

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@He-Pin
Copy link
Contributor

He-Pin commented May 5, 2020

Why remove it?

@typeness
Copy link
Author

typeness commented May 5, 2020

@hepin1989 IMO it's misleading, because it is under the section How to contribute.

@nicolasstucki
Copy link
Contributor

Indeed. We should have removed it a while ago.

@nicolasstucki nicolasstucki merged commit 4da1f25 into scala:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing error messages

4 participants