Handle -d /tmp on macos #8094
Merged
Handle -d /tmp on macos #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jan 26, 2020
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
Contributor
Author
|
Somebody let me know if Fix # notation is preferred in commit message header. |
Closed
Member
|
You need a "Fix #..." somewhere in the commit message to auto-close the issue when the PR is merged, but it doesn't necessarily need to be in the header. |
nicolasstucki
suggested changes
Jan 27, 2020
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
@som-snytt the commit message should mention #7646 (not #6450).
Contributor
|
The code LGTM |
When doing `mkdir -p`, don't fail if an enclosing dir is an existing symbolic link. Fix scala#7646
Contributor
Author
|
Squashed and fixed the noob Fix typo. |
nicolasstucki
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing
mkdir -p, don't fail if an enclosing diris an existing symbolic link.
The catch was added and then removed in previous commits,
but here it pertains only to the path to the parent, and is ignored
only if the parent actually exists.