Don't publish to sonatype twice #7803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quickfix to prevent CI from failing publish phases. Since other phases (such as github release) may depend on sonatype release, the fact that sonatype release fails may also fail these phases needlessly thus complicating the release process. We should do the publish of tasty core together with the other artefacts.
Member
|
this is the same as reverting #7724 |
bishabosha
requested changes
Dec 19, 2019
Member
bishabosha
left a comment
bishabosha
left a comment
There was a problem hiding this comment.
I think if this is just to fix the publish step crashing then the other PR should be reverted
smarter
reviewed
Dec 19, 2019
| - test_java11 | ||
| commands: | ||
| - ./project/scripts/sbtPublish ";project dotty-bootstrapped ;publishSigned ;sonatypeBundleRelease ;project tasty-core-scala2; publishSigned ;sonatypeBundleRelease" | ||
| - ./project/scripts/sbtPublish ";project dotty-bootstrapped ;publishSigned ;sonatypeBundleRelease" |
Member
There was a problem hiding this comment.
If the problem is that some artifacts get uploaded twice, we can clean the locally published artifacts in the middle:
Suggested change
| - ./project/scripts/sbtPublish ";project dotty-bootstrapped ;publishSigned ;sonatypeBundleRelease" | |
| - ./project/scripts/sbtPublish ";project dotty-bootstrapped ;publishSigned ;sonatypeBundleRelease ;sonatypeBundleClean ;project tasty-core-scala2; publishSigned ;sonatypeBundleRelease" |
Contributor
Author
There was a problem hiding this comment.
I don't think that'll help. The problem is not the staging area but maven central. By the time sonatypeBundleRelease finished, the staging area is promoted to maven central, and we can't clean up that.
Contributor
There was a problem hiding this comment.
If you figure something out, please let me know because I think I have been having the same problem. ekrich/sconfig#61
Contributor
Author
|
Superseded by #7823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quickfix to prevent CI from failing publish phases. Since other phases (such as github release) may depend on sonatype release, the fact that sonatype release fails may also fail these phases needlessly thus complicating the release process. We should do the publish of tasty core together with the other artefacts.