Upgrade Dotty Reference to 0.21.0-RC1 #7802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Dec 19, 2019
Done to match the location of the source to its package. The original source, thus, ends up split into two files in different packages. Since a sealed trait is involved, a new constructor for this trait is created to facilitate the access to this trait from the source that was moved from the original file.
anatoliykmetyuk
force-pushed
the
dotty-release-0.21.0-RC1
branch
from
18785b4 to
7437b6a
Compare
Member
|
I suggest just making the trait unsealed, it's the simplest fix. |
nicolasstucki
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.