Skip to content

Extract modules in reflection Type #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2019
Merged

Extract modules in reflection Type #7473

merged 2 commits into from
Oct 30, 2019

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Oct 30, 2019

This was done on Tree an all other types in TASTy reflect but we forgot to do it for Type.

@nicolasstucki
Extract modules in reflection Type
258bb7f 
This was done on Tree an all other types in TASTy reflect but we forgot to do it for Type
@nicolasstucki nicolasstucki self-assigned this Oct 30, 2019
@nicolasstucki nicolasstucki marked this pull request as ready for review October 30, 2019 12:08
liufengyun
liufengyun approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 1fe9555 into scala:master Oct 30, 2019
@nicolasstucki nicolasstucki deleted the flatten-tasty-reflect-type branch October 30, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolasstucki @liufengyun