Skip to content

Fix sbt scripted test after #7164 #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2019
Merged

Fix sbt scripted test after #7164 #7232

merged 3 commits into from
Sep 15, 2019

Conversation

@smarter
Copy link
Member

@smarter smarter commented Sep 15, 2019

No description provided.

@smarter smarter requested a review from milessabin September 15, 2019 12:54
@milessabin
Copy link
Contributor

milessabin commented Sep 15, 2019

Failed bootstrap?

@smarter
Increase timeout for bootstrapped tests
517cce0 
tests/run-staging/quote-toExprOfTuple.scala and
tests/run-staging/quote-run-many.scala failed with a timeout on the CI.
@odersky
Copy link
Contributor

odersky commented Sep 15, 2019

We currently get this on all PRs:


cp -R . /tmp/3/ && cd /tmp/3/
--
2 | + git submodule update --init --recursive --jobs 7
3 | error: Server does not allow request for unadvertised object 4ac9ab56bd6d123d4f04b8dfd7c6113791f7381b
4 | Fetched in submodule path 'community-build/community-projects/shapeless', but it did not contain 4ac9ab56bd6d123d4f04b8dfd7c6113791f7381b. Direct fetching of that commit failed.

@smarter
.drone.yml: Handle changes in submodule remote
b3a7025 
We need to run "git submodule sync" in case we picked up a submodule
remote change when merging master into this branch when running the CI.
@smarter
Copy link
Member Author

smarter commented Sep 15, 2019

@odersky Rebasing your PR on top of master should fix it. I've also added an extra commit in this PR which will prevent this issue from happening again.

@smarter smarter merged commit 6f6d973 into scala:master Sep 15, 2019
@smarter smarter deleted the fix-scripted-2 branch September 15, 2019 18:12
@smarter smarter mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milessabin milessabin Awaiting requested review from milessabin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarter @milessabin @odersky