Drop implicit match and given match #7203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
As expected, shapeless fails with this PR. |
Drop `given match` and `implict match` syntax. The docs on typeclass derivation still have to be updated to conform to the new terminology.
odersky
force-pushed
the
drop-implicit-match-1
branch
from
faba4c9 to
0c00c3b
Compare
Contributor
|
@odersky sorry for the hold up on this, but unfortunately the nightly builds have been failing for a few days now, and there still isn't a published build including However, after talking to @smarter I now realize that the preferred mechanism for including projects in the community build is via a fork in dotty-staging which doesn't need to be buildable from published compiler artefacts. So I've switched the shapeless in the community build to point to a new shapeless-3-staging branch in dotty-staging/shapeless (see #7230). This includes a change to |
milessabin
approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
given matchandimplict matchsyntax.The docs on typeclass derivation still have to be updated to conform to the
new terminology.