Fix #7159: Add missing asSeenFrom when updating denotations #7166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Yes, it passed the from-tasty tests. You can execute tests that run on the CI locally with |
For SingleDenotations that are not SymDenotations: Track the prefix under which they were created. This is necessary so that ElimOpaque can work correctly for such denotations.
Contributor
|
test performance please |
Member
|
performance test scheduled: 2 job(s) in queue, 1 running. |
nicolasstucki
approved these changes
Sep 6, 2019
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
LGTM
We should see what the benchmarks look like before merging
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/7166/ to see the changes. Benchmarks is based on merging with master (633696a) |
nicolasstucki
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicolasstucki I verified the fix solves #7159, but don't know how to make a test out of it. Maybe you can add one?