test symboo.defTree for symbols from Tasty #7036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
test-defTree
branch
5 times, most recently
from
d6e6080 to
10c6316
Compare
The scripted tests only run every night
This needs to be changed because `Pickler` does not exists for running staged code.
As the compiler supports already adding custom phases, there is no need to add the phases to the compiler.
The following invariant should be true for pattern-bound symbols,
and *only* for pattern-bound symbols:
(sym.isType && !sym.isClass && sym.isOneOf(Case)) ||
(sym.isTerm && sym.isOneOf(Case, butNot = Enum | Module))
The invariant only holds before patternMatcher.
After patternMatcher, there are no more pattern trees,
thus the invariant does not hold any more.
Those symbols are now normal ValDefs, thus should not have the Case flag.
liufengyun
force-pushed
the
test-defTree
branch
from
10c6316 to
9a629c3
Compare
Contributor
Author
|
@nicolasstucki Now this is rebased and simplified as discussed in the meeting. |
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
Otherwise look good
nicolasstucki
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test symboo.defTree for symbols from Tasty