Remove duplicate file, prevent sbt from compiling source files at root of project #6981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
remove-collectentrypoint
branch
2 times, most recently
from
fe5588b to
89801f9
Compare
nicolasstucki
approved these changes
Aug 3, 2019
allanrenucci
reviewed
Aug 5, 2019
nicolasstucki
approved these changes
Aug 8, 2019
Previously, creating a .scala file at the root of the dotty repository would cause sbt to try to compile it when typing `compile`, now it won't anymore.
We had two slightly different copies of the files: - the object in jvm/CEP is used in the backend, the class is unused - the class in transform/CEP is used as a compiler phase, however it doesn't do anything useful: it collects entry points but they're never used anywhere. This commit removes transform/CEP and add a comment about the dead code in jvm/CEP which we need to enable and test.
It never actually worked (see previous commit), we have no tests for it, and it's only useful for a marginal feature (when the compiler outputs a jar), better to remove dead code and wait for a usecase to appear.
smarter
force-pushed
the
remove-collectentrypoint
branch
from
897590d to
3ebf919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.