Fix #6720: implement extractor for function literals #6810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
suggested changes
Jul 4, 2019
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
8fe1d75 assumes that all lambdas are in their own block, but sometimes those blocks get flatten. I would feel uneasy adding this without the decompiler tests that we disabled.
Contributor
|
Or maybe we should make sure to enforce that shape as an invariant |
Contributor
Author
|
@nicolasstucki It's already done in #6767 by a new addition to Ycheck. |
nicolasstucki
approved these changes
Jul 4, 2019
nicolasstucki
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6720: implement extractor for function literals
Now as the encoding for function literal is a fixed invariant (#6767), we can implement an extractor for function literals.