Skip to content

Set spans of Child annotations #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Set spans of Child annotations #6752

merged 1 commit into from
Jun 27, 2019

Conversation

@odersky
Copy link
Contributor

@odersky odersky commented Jun 26, 2019

This is necessary to prevent unstability of pickled positions under -Ytest-pickler

@odersky
Set spans of Child annotations
e8e2385 
This is necessary to prevent unstability of pickled positions under -Ytest-pickler
@odersky odersky mentioned this pull request Jun 26, 2019
Merged
@odersky odersky requested a review from nicolasstucki June 26, 2019 14:08
nicolasstucki
nicolasstucki approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add the test that failed the picking test

@odersky
Copy link
Contributor Author

odersky commented Jun 27, 2019

It was the compiler itself :-)

@odersky odersky merged commit c3dbd50 into scala:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odersky odersky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@odersky @nicolasstucki