Fix atoms computation #6741
Merged
Fix atoms computation #6741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
test performance please |
It's possible that a singleton type has a disjunction of singleton types as underlying type. In this case `atoms` of the first type should return the disjunction, not the singleton type itself.
odersky
force-pushed
the
fix-subtype-bottom
branch
from
5769aa5 to
f94fdda
Compare
odersky
changed the title
Contributor
Author
|
test performance please |
Member
|
performance test scheduled: 1 job(s) in queue, 1 running. |
Member
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6741/ to see the changes. Benchmarks is based on merging with master (10526a7) |
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 26, 2019
Even the mitigation would have needed a workaround (because of scala#6741).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a singleton type has a disjunction of singleton types
as underlying type. In this case
atomsof the first type should returnthe disjunction, not the singleton type itself.