Fix #6724: Don't suggest types for terms and vice versa #6735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter candidate definitions for member suggestions to be either types or terms, depending on the selection name.
smarter
approved these changes
Jun 24, 2019
kubukoz
reviewed
Jun 24, 2019
| 1 | import util.foo | ||
| | ^^^ | ||
| | value foo is not a member of util - did you mean util.Left? | ||
| | value foo is not a member of util - did you mean util.Try? |
Contributor
There was a problem hiding this comment.
Could you explain this one to me? import util.Left is invalid? Or did it change because Try has a higher priority on the list of suggestions?
Member
There was a problem hiding this comment.
Or did it change because Try has a higher priority on the list of suggestions?
Something like that yeah. Ideally it should just not offer any suggestion at all when there's nothing close to what the user has written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter candidate definitions for member suggestions to be either types or terms,
depending on the selection name.