Skip to content

Correct small typo in macros example #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Correct small typo in macros example #6690

merged 1 commit into from
Jun 18, 2019

Conversation

@stevenheidel
Copy link
Contributor

@stevenheidel stevenheidel commented Jun 15, 2019 •
edited
Loading

Correction 2 of 3 that I found while reading the docs last night.

dottybot
dottybot reviewed Jun 15, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jun 17, 2019

@stevenheidel you will need to sign the CLA at https://www.lightbend.com/contribute/cla/scala.

Otherwise the changes look good to me.

@nicolasstucki nicolasstucki self-assigned this Jun 17, 2019
@biboudis
Copy link
Contributor

biboudis commented Jun 17, 2019

Change looks good @stevenheidel! Thanks!

I noticed your other PRs. We usually try to contain changes as a unit of work. I think we can merge these now but next time it would be more convenient if you would contain all relevant changes (e.g., Fixes at docs) as one PR. A draft PR is preferable if you have work in progress!

Despite this, a big thanks that you took the time to have a look and make the fixes 🎉

@stevenheidel
Copy link
Contributor Author

stevenheidel commented Jun 17, 2019

Will do in the future, thanks. Also I just signed the CLA 👍

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jun 18, 2019

CLA verified https://www.lightbend.com/contribute/cla/scala/check/stevenheidel

@nicolasstucki nicolasstucki merged commit db3ab9e into scala:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nicolasstucki nicolasstucki

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevenheidel @nicolasstucki @biboudis @dottybot