Skip to content

[Docs] consistent use of subscripts, link to sections #6681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2019
Merged

[Docs] consistent use of subscripts, link to sections #6681

merged 1 commit into from
Jun 17, 2019

Conversation

@robstoll
Copy link
Contributor

@robstoll robstoll commented Jun 14, 2019

  • I turned A_1 into A1 to be consistent with other examples on this page but also on others.
  • Please fell free to squash the commits during the merge.

dottybot
dottybot reviewed Jun 14, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@biboudis
Copy link
Contributor

biboudis commented Jun 14, 2019 •
edited
Loading

Thank you and seems good. Can you squash and force push to your branch before I merge?

@robstoll
Copy link
Contributor Author

robstoll commented Jun 14, 2019

@biboudis I haven't cloned the project (worked only from the GitHub-UI) and don't have the possibility to do that via UI (as far as I know). However, you can squash the commits during the merge: https://help.github.com/en/articles/about-pull-request-merges#squash-and-merge-your-pull-request-commits
If you don't mind doing the squash yourself I would be glad, otherwise I clone repo and do it myself (yet, then maybe in the evening)

@robstoll
Copy link
Contributor Author

robstoll commented Jun 14, 2019

@biboudis I squashed the commits

biboudis
biboudis suggested changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you can remove that "yet not less" and fix something additional I noticed I'll merge!

Thanks!

@robstoll
[docs] consistent use of subscripts, fix links
caaa6de 
moreover:
- write out wrt
- generalise union and intersection types to n types
- fix links, use ‘’ for grammer
@robstoll
Copy link
Contributor Author

robstoll commented Jun 17, 2019

fixed all things, and force-pushed again

@biboudis biboudis merged commit d3433a6 into scala:master Jun 17, 2019
@robstoll robstoll deleted the docs branch June 17, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@biboudis biboudis biboudis requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robstoll @biboudis @dottybot