Skip to content

Fix syntax for derivation docs #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

Fix syntax for derivation docs #6673

merged 1 commit into from
Jun 12, 2019

Conversation

@bishabosha
Copy link
Member

@bishabosha bishabosha commented Jun 12, 2019

  • remove class from enum cases
  • close markdown comment
  • remove orphan code block opening

dottybot
dottybot reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

liufengyun
liufengyun approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution @bishabosha 🎉

@liufengyun liufengyun merged commit 47c126a into scala:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dottybot dottybot dottybot left review comments

@liufengyun liufengyun liufengyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bishabosha @liufengyun @dottybot