Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

Add missing workaround of XMLBlock positions. This is used in Positioned.scala#L179 to avoid an assertion failure.

This issue is mesing a test in the string interpolator macro project where <foo a="hello &name; aaa"/> crashes dotty while xml"""<foo a="hello &name; aaa"/>""" works.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit bb25f19 into scala:master May 22, 2019
@liufengyun liufengyun deleted the fix-xml-block branch May 22, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants