Skip to content

Add test case for typesafe compile-time stripMargin #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add test case for typesafe compile-time stripMargin #6202

merged 1 commit into from
Apr 1, 2019

Conversation

@liufengyun
Copy link
Contributor

@liufengyun liufengyun commented Apr 1, 2019

Add test case for typesafe compile-time stripMargin

nicolasstucki
nicolasstucki reviewed Apr 1, 2019
View reviewed changes
@liufengyun
Copy link
Contributor Author

liufengyun commented Apr 1, 2019

@cheeseng The .stripMargin on string literals in assertCompiles could be implemented as a macro in a nice way in Dotty. The type system will ensure that the string to assertCompiles is always a constant.

@nicolasstucki nicolasstucki merged commit f62e286 into scala:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liufengyun @nicolasstucki