Split quoted.Expr casting from sealing #6189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
split-unseal-and-cast
branch
from
50c4f3f to
347bb33
Compare
Contributor
Author
|
Rebased |
Previously `seal` always casted the `quoted.Expr[T]` for some given `T`. Now, `seal` and `cast` can be used independently. If we need to seal to an `Expr[Any]` there is no need to check the that the type conforms. This use-case is common enough to deserve the optimization. Additionally, due to bootstrapping issues, it is not practical to seal to a `quoted.Expr[Any]` within the library as we cannot create a `quoted.Type[Any]`.
nicolasstucki
force-pushed
the
split-unseal-and-cast
branch
from
347bb33 to
a70a1f3
Compare
biboudis
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
sealalways casted thequoted.Expr[T]for some givenT. Now,sealandcastcan be used independently. If we need to seal to anExpr[Any]there is no need to check the that the type conforms. This use-case is common enough to deserve the optimization.Additionally, due to bootstrapping issues, it is not practical to seal to a
quoted.Expr[Any]within the library as we cannot create aquoted.Type[Any].This is needed #6042