- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
Move Staging to Typer #5846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Move Staging to Typer #5846
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    361f777    to
    20447f1      
    Compare
  
    b30731f    to
    177373a      
    Compare
  
    177373a    to
    326465f      
    Compare
  
    | @nicolasstucki Can you explain the motivation for this change? | 
| Mainly to support whitebox macros | 
08d6113    to
    867e7dc      
    Compare
  
    defc91e    to
    0693667      
    Compare
  
    | I only have one more comment on the last commit. Otherwise it's good. | 
1a192fa    to
    a6dcc2e      
    Compare
  
    This adds support for whitebox macros
a6dcc2e    to
    cb4497a      
    Compare
  
    Macros seem to be expanded before the comments are registered in the symbol. Comments where added to be used while loadind a TASTy file trough the tasty.Reflection API, hence this use case is not critical. See scala#6032
| Rebased | 
              
                    odersky
  
              
              approved these changes
              
                  
                    Mar 7, 2019 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
The main motivation for moving staging to typer is to support whitebox macros.
Using the
<: Treturn type notation.Modification:
Stagingis used inTyperto check contents of inline macrosInlinerdurring typing