Add tasty.reflect.utils #5685
Merged
Add tasty.reflect.utils #5685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-tasty-utils
branch
from
6172e35 to
f2cf246
Compare
With implementation of `def let(rhs: Term)(in: Term.Ident => Term): Term`
nicolasstucki
force-pushed
the
add-tasty-utils
branch
3 times, most recently
from
67fc1de to
cff4a78
Compare
liufengyun
reviewed
Jan 14, 2019
Contributor
liufengyun
left a comment
liufengyun
left a comment
There was a problem hiding this comment.
LGTM, except that the repeated usage of seal.asExprOf suggests that we should keep a short-cut API for friendliness.
Contributor
Author
|
Actually the current definition of |
nicolasstucki
force-pushed
the
add-tasty-utils
branch
from
d83dbe7 to
1199f85
Compare
Contributor
Author
|
I removed the alternative to #5651 which was unsound. The solution will be an improvement on sealing types that will be needed but we can work around it for now with casts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With implementation of
def let(rhs: Term)(in: Term.Ident => Term): Term.This version allows sealing terms even if the type is not statically known while keeping the type safety guarantees on quoted expressions.
Added reflective
tpeonquoted.Expr[T]to get itsquoted.Type[T]even whenTis just an existential type.Added
asExprOfto cast anExpr[_]to anExpr[U]. Fails if the expression is not a subtype ofU.Use
asExprOf[T]when needed.