Skip to content

Conversation

@michelou
Copy link
Contributor

Character encoding is wrong when piping stdout on Windows, e.g. test case test\run\productElementName.scala contains UTF-8 characters and fails with the following output:

[info] Test dotty.tools.dotc.CompilationTests.runAll started
Output from "tests\run\productElementName.scala" did not match check file.6s)
Diff (expected on the left, actual right):
User(name=Susan, age=42)                             |  User(name=Susan, age=42)
????(??=Susan, ??=42)                                |  ????(??=Susan, ??=42)
U$er(na$me=Susan, a$ge=42)                           |  U$er(na$me=Susan, a$ge=42)
type(for=Susan, if=42)                               |  type(for=Susan, if=42)
contains spaces(first param=Susan, second param=42)  |  contains spaces(first param=Susan, second param=42)
Symbols(::=Susan, ||=42)                             |  Symbols(::=Susan, ||=42)
MultipleParamLists(a=Susan, b=42)                    |  MultipleParamLists(a=Susan, b=42)
AuxiliaryConstructor(a=Susan, b=42)                  |  AuxiliaryConstructor(a=Susan, b=42)
OverloadedApply(a=Susan, b=123)                      |  OverloadedApply(a=Susan, b=123)
PrivateMembers(a=10, b=20, c=30, d=40, e=50, f=60)   |  PrivateMembers(a=10, b=20, c=30, d=40, e=50, f=60)

NoParams()                                           |  NoParams()
EOF                                                  |  EOF

[=======================================] completed (1123/1123, 1 failed, 101s)
[error] Test dotty.tools.dotc.CompilationTests.runAll failed: java.lang.AssertionError: Run test failed, but should not, reasons:
[error]
[error]   - encountered 1 test failures(s), took 113.944 sec
[error]     at dotty.tools.vulpix.ParallelTesting$CompilationTest.checkRuns(ParallelTesting.scala:1008)
[error]     at dotty.tools.dotc.CompilationTests.runAll(CompilationTests.scala:176)
[error]     ...

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@michelou
Copy link
Contributor Author

See also Problems with UTF-8 support for Windows.

@allanrenucci allanrenucci merged commit 7b9ffbb into scala:master Dec 25, 2018
@michelou michelou deleted the utf8-pipe branch February 10, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants