Skip to content

Memoize SourceFile creation #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2018
Merged

Memoize SourceFile creation #5642

merged 2 commits into from
Dec 19, 2018

Conversation

@odersky
Copy link
Contributor

@odersky odersky commented Dec 18, 2018

No description provided.

@odersky odersky changed the title Memoize sourceFile creation Memoize SourceFile creation Dec 18, 2018
@allanrenucci
Copy link
Contributor

allanrenucci commented Dec 18, 2018

This could be updated: https://github.com/lampepfl/dotty/blob/b654af7b427ea485885d852ae0d644d1eecfa981/doc-tool/src/dotty/tools/dottydoc/util/syntax.scala#L24

liufengyun
liufengyun approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 4d10f68 into scala:master Dec 19, 2018
@allanrenucci allanrenucci deleted the add-sourcepos branch December 19, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@odersky @allanrenucci @liufengyun