Skip to content

Add dotty-library to generated docs #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add dotty-library to generated docs #5499

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4609aeb
Add dotty-library to generated docs
nicolasstucki Nov 22, 2018
74be121
sbt genDocs: use the bootstrapped library sources
smarter Nov 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,8 @@ object Build {

val sources =
unmanagedSources.in(Compile, compile).value ++
unmanagedSources.in(`dotty-compiler`, Compile).value
unmanagedSources.in(`dotty-compiler`, Compile).value ++
unmanagedSources.in(`dotty-library`, Compile).value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be dotty-library-bootstrapped, otherwise you'll misss the Scala 3-only files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buy adding dotty-library-bootstrapped (dc5a442) sbt crashes with a stack overflow.

http://dotty-ci.epfl.ch/lampepfl/dotty/8824/4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix, but genDocs now fails because it doesn't know how to handle MatchType, I'll let someone else fix that :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll work on the MatchType

val args = Seq(
"-siteroot", "docs",
"-project", "Dotty",
Expand Down