Skip to content

Conversation

@milessabin
Copy link
Contributor

Sort files for compileStbLib test to illustrate compilation order dependencies.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@milessabin
Copy link
Contributor Author

The failures here demonstrate that there's a compilation order bug lurking here somewhere.

@milessabin milessabin force-pushed the wip/compilation-order branch from fe975f6 to 85ce94e Compare November 22, 2018 15:37
@smarter smarter self-assigned this Dec 10, 2018
@odersky
Copy link
Contributor

odersky commented Jan 12, 2019

@smarter I assume this can be closed since you are on it?

@smarter
Copy link
Member

smarter commented Jan 12, 2019

Yes.

@smarter smarter closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants