Record anonymous child classes for exhaustivity check #5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nicolasstucki could you please give some help with the decompile failure in CI? I run the following on my local machine: It works without any problem. |
Contributor
|
I will have a look |
Contributor
|
@liufengyun the issue was not a fromtasty compilation one. It was about recompiling decompiled code. I remove it from the whitelist. Now it should work. |
Contributor
|
@liufengyun you still have a pickling test failing (t8611b) |
Contributor
Author
|
Thanks a lot @nicolasstucki for the fix. |
If a sealed class A has local or anonymous classes, add the annotation `Child(A)` to `A`. With this simple change, the exhaustivity check works without any modification.
liufengyun
force-pushed
the
check-anonym
branch
from
6bb198a to
1a8eefe
Compare
odersky
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record anonymous child classes for exhaustivity check