Fix unescaping of escape sequences by jline in REPL #5298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 19, 2018
Member
dottybot
left a comment
dottybot
left a comment
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
| .variable(BLINK_MATCHING_PAREN, 0L) // Don't blink the opening paren after typing a closing paren. | ||
| .option(INSERT_TAB, true) // At the beginning of the line, insert tab instead of completing. | ||
| .option(AUTO_FRESH_LINE, true) // if not at start of line before prompt, move to new line. | ||
| .option(DISABLE_EVENT_EXPANSION, true) |
Contributor
There was a problem hiding this comment.
Can you add a comment explaining why
Contributor
Author
There was a problem hiding this comment.
@allanrenucci I have added the comment.
Is it understandable?
allanrenucci
approved these changes
Oct 22, 2018
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
LGTM. Thanks @nrjais!
Note that we usually expect regression tests with fixes. But we currently don't have any infrastructure to test the JLine integration so I'll merge as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5294
Output