Fix #5242: Don't run all Scala files as worksheets #5244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing the `WorksheetRunFeature`, we were specifying that the feature should apply to all files where the `document selector` matches that of the Dotty plugin, or files in the Scala language whose name ends in `.sc`. Unfortunately, this matches all `.scala` files, and these were run as worksheets. This commit changes the document selector for the `WorksheetRunFeature` so that Scala files are not run as if they were worksheets.
nicolasstucki
approved these changes
Oct 11, 2018
Contributor
nicolasstucki
left a comment
nicolasstucki
left a comment
There was a problem hiding this comment.
LGTM, tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing the
WorksheetRunFeature, we were specifying that thefeature should apply to all files where the
document selectormatchesthat of the Dotty plugin, or files in the Scala language whose name ends
in
.sc. Unfortunately, this matches all.scalafiles, and these wererun as worksheets.
This commit changes the document selector for the
WorksheetRunFeatureso that Scala files are not run as if they were worksheets.