Skip to content

Conversation

@0xflotus
Copy link
Contributor

@0xflotus 0xflotus commented Oct 4, 2018

No description provided.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@allanrenucci
Copy link
Contributor

Hi @0xflotus. Thanks for the contribution! Please sign the Scala CLA at https://www.lightbend.com/contribute/cla/scala

@0xflotus
Copy link
Contributor Author

0xflotus commented Oct 5, 2018

Hi @0xflotus. Thanks for the contribution! Please sign the Scala CLA at https://www.lightbend.com/contribute/cla/scala

done. :)

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLA signed. Thanks @0xflotus!

@allanrenucci allanrenucci merged commit 719f5e2 into scala:master Oct 8, 2018
@0xflotus 0xflotus deleted the patch-1 branch October 8, 2018 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants