Skip to content

Add message CheckStatic for member with same name as @static one #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add message CheckStatic for member with same name as @static one #5197

merged 1 commit into from
Oct 8, 2018

Conversation

@john-eevee
Copy link
Contributor

@john-eevee john-eevee commented Oct 4, 2018 •
edited
Loading

For when a class has a member with the same name as a static
member on its companion, E.g

class Camp {
  val name = ???
}
object Camp {
  @static val name = ???
}

Part of #1589

dottybot
dottybot reviewed Oct 4, 2018
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

allanrenucci
allanrenucci approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks @sleepiejohn

@john-eevee
Add message CheckStatic
7c1eb58 
For when a class has a member with same name as a static
member on it's companion
@allanrenucci allanrenucci merged commit 7463afe into scala:master Oct 8, 2018
@allanrenucci
Copy link
Contributor

allanrenucci commented Oct 8, 2018

Thanks again @sleepiejohn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@allanrenucci allanrenucci allanrenucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@john-eevee @allanrenucci @dottybot