Add defTree field to symbols
#5131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
add-tree-field
branch
3 times, most recently
from
86620c9 to
6a5aec8
Compare
As a first step, rename all occurrences of `rewrite` to `inline`.
Analogous to `&` and `|`, treat `inline` as an identifier but intrepret it specially if it appears in places where it influences the syntax. This allows us to keep `@inline` as an annotation.
Rename `tree`, `trees` and associated methods in `ClassSymbol` to `rootTree`, `rootTrees`. We want to add another tree field to symbols that points directly to the symbol's definition tree. So we should be more specific about `rootTree`.
odersky
force-pushed
the
add-tree-field
branch
from
6a5aec8 to
819d9f6
Compare
nicolasstucki
approved these changes
Sep 20, 2018
nicolasstucki
suggested changes
Sep 20, 2018
|
I saw the issue with a def that contained inlined code. The call of the |
| val sym = tree.symbol | ||
| sym.registerIfChild() | ||
| sym.transformAnnotations(transformAnnot) | ||
| sym.defTree = tree |
There was a problem hiding this comment.
I referred to this tree
There was a problem hiding this comment.
I have an alternative fix in 241122e of #5138. @nicolasstucki can you review this one?
|
I have a fix in f3885ac. |
|
This PR and a proposed fix is part of #5138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
defTreefield that gets set for certain symbols.Some possible uses: