Respect -color:never in REPL output
#5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
suggested changes
Sep 12, 2018
Contributor
allanrenucci
left a comment
allanrenucci
left a comment
There was a problem hiding this comment.
I think SyntaxHighlighting.apply should take a Context and only highlight if settings.color.value != "never". That's how it's done in #4537
If `-color:never` is set, the REPL will not do any syntax highlighting.
Duhemm
force-pushed
the
fix/repl-nocolor-highlighting
branch
from
cad0686 to
a592293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (successful) result of the REPL was highlighted regardless of the
value of
-color. This commit fixes this, so that the output of theREPL is highlighted only if
-coloris not set tonever.The prompt and the code as being entered are still highlighted.